<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.E-MailFormatvorlage18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Is this a better commit message?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">„use new 8250 debug uart code because the old mach-mcs814x/include/mach/debug-macro.S tries to include<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">asm/hardware/debug-8250.S which no longer exists since kernel 3.14”<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Günther<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> f.fainelli@gmail.com [mailto:f.fainelli@gmail.com]
<b>On Behalf Of </b>Florian Fainelli<br>
<b>Sent:</b> Monday, July 27, 2015 7:53 PM<br>
<b>To:</b> Guenther Kelleter<br>
<b>Cc:</b> OpenWrt Development List<br>
<b>Subject:</b> Re: [OpenWrt-Devel] [PATCH v2 1/3] mcs814x: fix debug UART<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p>On Jul 27, 2015 3:54 AM, "Günther Kelleter" <<a href="mailto:guenther.kelleter@devolo.de">guenther.kelleter@devolo.de</a>> wrote:<br>
><br>
> It was broken since kernel 3.14<o:p></o:p></p>
<p>True, but your patch does not explain how you are fixing this, which is what matters for a good commit message. Could expand on why migrating to the generic 8250 debug uart code is fixing things?<o:p></o:p></p>
<p>><br>
> Signed-off-by: Günther Kelleter <<a href="mailto:guenther.kelleter@devolo.de">guenther.kelleter@devolo.de</a>><br>
> ---<br>
> target/linux/mcs814x/config-3.18 | 10 ++++--<br>
> .../linux/mcs814x/patches-3.18/014-debuguart.patch | 41 ++++++++++++++++++++++<br>
> 2 files changed, 48 insertions(+), 3 deletions(-)<br>
> create mode 100644 target/linux/mcs814x/patches-3.18/014-debuguart.patch<br>
><br>
> diff --git a/target/linux/mcs814x/config-3.18 b/target/linux/mcs814x/config-3.18<br>
> index 87a8382..e57f5ff 100644<br>
> --- a/target/linux/mcs814x/config-3.18<br>
> +++ b/target/linux/mcs814x/config-3.18<br>
> @@ -49,10 +49,15 @@ CONFIG_CRYPTO_CRC32C=y<br>
> CONFIG_CRYPTO_HASH=y<br>
> CONFIG_CRYPTO_HASH2=y<br>
> CONFIG_DEBUG_LL=y<br>
> -CONFIG_DEBUG_LL_INCLUDE="mach/debug-macro.S"<br>
> +CONFIG_DEBUG_LL_INCLUDE="debug/8250.S"<br>
> CONFIG_DEBUG_LL_UART_NONE=y<br>
> -# CONFIG_DEBUG_UART_8250 is not set<br>
> +CONFIG_DEBUG_UART_8250=y<br>
> +# CONFIG_DEBUG_UART_8250_FLOW_CONTROL is not set<br>
> +CONFIG_DEBUG_UART_8250_SHIFT=2<br>
> +# CONFIG_DEBUG_UART_8250_WORD is not set<br>
> +CONFIG_DEBUG_UART_PHYS=0x400dc000<br>
> # CONFIG_DEBUG_UART_PL01X is not set<br>
> +CONFIG_DEBUG_UART_VIRT=0xf00dc000<br>
> # CONFIG_DEBUG_USER is not set<br>
> CONFIG_DTC=y<br>
> CONFIG_EARLY_PRINTK=y<br>
> @@ -157,7 +162,6 @@ CONFIG_MTD_PHYSMAP=y<br>
> CONFIG_MULTI_IRQ_HANDLER=y<br>
> CONFIG_NEED_DMA_MAP_STATE=y<br>
> CONFIG_NEED_KUSER_HELPERS=y<br>
> -CONFIG_NEED_MACH_MEMORY_H=y<br>
> CONFIG_NEED_PER_CPU_KM=y<br>
> CONFIG_NET_KEY=y<br>
> # CONFIG_NET_VENDOR_BROADCOM is not set<br>
> diff --git a/target/linux/mcs814x/patches-3.18/014-debuguart.patch b/target/linux/mcs814x/patches-3.18/014-debuguart.patch<br>
> new file mode 100644<br>
> index 0000000..5f1b67f<br>
> --- /dev/null<br>
> +++ b/target/linux/mcs814x/patches-3.18/014-debuguart.patch<br>
> @@ -0,0 +1,41 @@<br>
> +--- a/arch/arm/mach-mcs814x/include/mach/debug-macro.S<br>
> ++++ /dev/null<br>
> +@@ -1,11 +0,0 @@<br>
> +-#include <mach/mcs814x.h><br>
> +-<br>
> +- .macro addruart, rp, rv, tmp<br>
> +- ldr \rp, =MCS814X_PHYS_BASE<br>
> +- ldr \rv, =MCS814X_VIRT_BASE<br>
> +- orr \rp, \rp, #MCS814X_UART<br>
> +- orr \rv, \rv, #MCS814X_UART<br>
> +- .endm<br>
> +-<br>
> +-#define UART_SHIFT 2<br>
> +-#include <asm/hardware/debug-8250.S><br>
> +--- a/arch/arm/Kconfig.debug<br>
> ++++ b/arch/arm/Kconfig.debug<br>
> +@@ -1089,7 +1089,7 @@ config DEBUG_UART_8250<br>
> + (FOOTBRIDGE && !DEBUG_DC21285_PORT) || \<br>
> + ARCH_GEMINI || ARCH_IOP13XX || ARCH_IOP32X || \<br>
> + ARCH_IOP33X || ARCH_IXP4XX || \<br>
> +- ARCH_LPC32XX || ARCH_MV78XX0 || ARCH_ORION5X || ARCH_RPC<br>
> ++ ARCH_LPC32XX || ARCH_MCS814X || ARCH_MV78XX0 || ARCH_ORION5X || ARCH_RPC<br>
> +<br>
> + # Compatibility options for BCM63xx<br>
> + config DEBUG_UART_BCM63XX<br>
> +@@ -1124,6 +1124,7 @@ config DEBUG_UART_PHYS<br>
> + default 0x3e000000 if DEBUG_BCM_KONA_UART<br>
> + default 0x4000e400 if DEBUG_LL_UART_EFM32<br>
> + default 0x40090000 if ARCH_LPC32XX<br>
> ++ default 0x400dc000 if ARCH_MCS814X<br>
> + default 0x40100000 if DEBUG_PXA_UART1<br>
> + default 0x42000000 if ARCH_GEMINI<br>
> + default 0x50000000 if DEBUG_S3C24XX_UART && (DEBUG_S3C_UART0 || \<br>
> +@@ -1178,6 +1179,7 @@ config DEBUG_UART_VIRT<br>
> + default 0xe0010fe0 if ARCH_RPC<br>
> + default 0xe1000000 if DEBUG_MSM_UART<br>
> + default 0xf0000be0 if ARCH_EBSA110<br>
> ++ default 0xf00dc000 if ARCH_MCS814X<br>
> + default 0xf01fb000 if DEBUG_NOMADIK_UART<br>
> + default 0xf0201000 if DEBUG_BCM2835<br>
> + default 0xf1000300 if DEBUG_BCM_5301X<br>
> --<br>
> 2.4.6.89.g851dcf4<br>
> _______________________________________________<br>
> openwrt-devel mailing list<br>
> <a href="mailto:openwrt-devel@lists.openwrt.org">openwrt-devel@lists.openwrt.org</a><br>
> <a href="https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel">https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel</a><o:p></o:p></p>
</div>
</div>
</body>
</html>