<div dir="ltr">Hi,<div><br></div><div>Is it OK now?</div><div><br></div><div><span style="font-size:12.8000001907349px;color:rgb(80,0,80)">Signed-off-by: Aleksandr Kolesnik <<a href="mailto:neryba@gmail.com" target="_blank">neryba@gmail.com</a>></span><br style="font-size:12.8000001907349px;color:rgb(80,0,80)"></div><div><span style="font-size:12.8000001907349px;color:rgb(80,0,80)"><br></span></div><div><div>--- a/package/network/utils/comgt/files/ncm.sh</div><div>+++ b/package/network/utils/comgt/files/ncm.sh</div><div>@@ -27,6 +27,8 @@ proto_ncm_setup() {</div><div> <span class="" style="white-space:pre">       </span>local device apn auth username password pincode delay mode</div><div> <span class="" style="white-space:pre">       </span>json_get_vars device apn auth username password pincode delay mode</div><div> </div><div>+<span class="" style="white-space:pre">       </span>[ -n "$ctl_device" ] && device=$ctl_device</div><div>+<span class="" style="white-space:pre">      </span></div><div> <span class="" style="white-space:pre"> </span>[ -n "$device" ] || {</div><div> <span class="" style="white-space:pre">          </span>echo "No control device specified"</div><div> <span class="" style="white-space:pre">             </span>proto_notify_error "$interface" NO_DEVICE</div></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-07-07 15:03 GMT+03:00 John Crispin <span dir="ltr"><<a href="mailto:blogic@openwrt.org" target="_blank">blogic@openwrt.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
patch is generated against the wrong root folder. also your mail client<br>
replaced tabs with spaces. please fix and resend the patch<br>
<br>
        John<br>
<br>
On 22/04/2015 15:26, Aleksandr Kolesnik wrote:<br>
> Signed-off-by: Aleksandr Kolesnik <<a href="mailto:neryba@gmail.com">neryba@gmail.com</a><br>
> <mailto:<a href="mailto:neryba@gmail.com">neryba@gmail.com</a>>><br>
<div><div class="h5">><br>
> --- package/network/utils/comgt/files/ncm.sh<br>
> +++ package/network/utils/comgt/files/ncm.sh<br>
> @@ -27,6 +27,8 @@ proto_ncm_setup() {<br>
>  local device apn auth username password pincode delay mode<br>
>  json_get_vars device apn auth username password pincode delay mode<br>
><br>
> +[ -n "$ctl_device" ] && device=$ctl_device<br>
> +<br>
>  [ -n "$device" ] || {<br>
>  echo "No control device specified"<br>
>  proto_notify_error "$interface" NO_DEVICE<br>
><br>
><br>
</div></div>> _______________________________________________<br>
> openwrt-devel mailing list<br>
> <a href="mailto:openwrt-devel@lists.openwrt.org">openwrt-devel@lists.openwrt.org</a><br>
> <a href="https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel" rel="noreferrer" target="_blank">https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel</a><br>
><br>
</blockquote></div><br></div>