<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 18, 2015 at 9:18 AM, Rafał Miłecki <span dir="ltr"><<a href="mailto:zajec5@gmail.com" target="_blank">zajec5@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Rafał Miłecki <<a href="mailto:zajec5@gmail.com">zajec5@gmail.com</a>><br>
---<br>
When reading bcmrobo.c code for BCM5301X I've noticed that it uses<br>
REG_CTRL_MIIPO (0x0e) with a following comment:<br>
/* default(1 << 1) DUPLX_MODE:<br>
 * Full Duplex<br>
 */<br>
So I guess our bit definition may be reversed. Can someone verify this?<br>
---<br>
 target/linux/generic/files/drivers/net/phy/b53/b53_regs.h | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h b/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h<br>
index ba50915..4899cc4 100644<br>
--- a/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h<br>
+++ b/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h<br>
@@ -75,7 +75,7 @@<br>
 /* IMP Port state override register (8 bit) */<br>
 #define B53_PORT_OVERRIDE_CTRL         0x0e<br>
 #define   PORT_OVERRIDE_LINK           BIT(0)<br>
-#define   PORT_OVERRIDE_HALF_DUPLEX    BIT(1) /* 0 = Full Duplex */<br>
+#define   PORT_OVERRIDE_FULL_DUPLEX    BIT(1) /* 0 = Half Duplex */<br>
 #define   PORT_OVERRIDE_SPEED_S                2<br>
 #define   PORT_OVERRIDE_SPEED_10M      (0 << PORT_OVERRIDE_SPEED_S)<br>
 #define   PORT_OVERRIDE_SPEED_100M     (1 << PORT_OVERRIDE_SPEED_S)<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.4.5<br>
_______________________________________________<br>
openwrt-devel mailing list<br>
<a href="mailto:openwrt-devel@lists.openwrt.org">openwrt-devel@lists.openwrt.org</a><br>
<a href="https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel" target="_blank">https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel</a><br>
</font></span></blockquote></div><br></div><div class="gmail_extra">I can validate that this fix is correct on my BCM53128.</div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div></div>