<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-01-27 1:10 GMT+08:00 Roger Pueyo Centelles <span dir="ltr"><<a href="mailto:rogerpueyo@rogerpueyo.com" target="_blank">rogerpueyo@rogerpueyo.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><span class=""><div>Hi,<br><br></div>Thank you both for your comments.<br></span><div><br>@郭传鈜:<br><span class=""><br>>> + ucidef_set_led_wlan "wlan2g" "WLAN2G" "mercury:green:wlan2g" "phy1tpt"<br></span><span class="">> I think the following line is incorrect:</span><span class=""><span><br>>> + ucidef_set_led_wlan "wlan5g" "WLAN5G" "mercury:green:wlan5g" "phy0tpt"<br></span></span><span class="">> There is no LED trigger called 'phy0tpt' so I think we should use netdev trigger like this:<br></span>> ucidef_set_led_netdev "wlan5g" "WLAN5G" "mercury:green:wlan5g" "wlan0"<br></div><div><br>Ok!<span class=""><br><br><br>>> +static struct gpio_keys_button mac1200r_gpio_keys[] __initdata = {<br>>> + {<br>>> + .desc = "WPS button",<br>>> + .type = EV_KEY,<br>>> + .code = KEY_WPS_BUTTON,<br>>> + .debounce_interval = MAC1200R_KEYS_DEBOUNCE_INTERVAL,<br></span><div><span class="">>> + .gpio = MAC1200R_GPIO_BTN_WPS,<br>>> + .active_low = 1,<br>>> + },<br>>> +};<br></span><span class="">> Although the key is called WPS/RESET , I think a reset button is more
important than a WPS button.That's just my personal opinion :)<br></span></div><span class=""><div><br>I think you are right.<br></div><br><br></span><span class="">>> + ap91_pci_init(art + MAC1200R_PCIE_CALDATA_OFFSET, tmpmac);<br></span><span class="">> What? I think this function is only able to load CALDATA for ath9k devices.Maybe I'm wrong:)<br></span></div><span class=""><div><br></div><div>The
router has two radios, one ath9k and one ath10k. Isn't it needed for
the ath9k calibration data? Or this radio is already covered by
"ath79_register_wmac(art + MAC1200R_WMAC_CALDATA_OFFSET, tmpmac); ...?<br><br></div></span></div></div></blockquote><div><span style="font-size:14px">Acoording to mach-archer-c7.c ,I think we should use ath79_register_pci(); here and use /lib/preinit/81_load_ath10k_</span><span style="font-size:14px">board_bin to load calibration data for ath10k.</span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><span class=""><div><br><div>>> +$(eval $(call SingleProfile,TPLINK-LZMA,64kraw,MAC1200R,mc-mac1200r,MC-MAC1200R,ttyS0,115200,0x12000001,1,8Mlzma))<br></div><div>>The
factory image is broken since TP-LINK started to use a new firmware
format with RSA signature in China.This should be introduced in the TOH
wiki I think:)<br><br></div><div>Done!<br><br><br><br></div><div>@John:<br><br></div>Sorry. Do you mean a description for the patch? I am not aware of what SoB means.<br><br><br></div><div>Thanks!<br><br>Roger</div></span></div></div>
<br>_______________________________________________<br>
openwrt-devel mailing list<br>
<a href="mailto:openwrt-devel@lists.openwrt.org">openwrt-devel@lists.openwrt.org</a><br>
<a href="https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel" target="_blank">https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel</a><br>
<br></blockquote></div><br></div></div>