<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Bastian:<br><br><div>> Date: Sat, 18 Oct 2014 22:37:59 +0200<br>> From: bittorf@bluebottle.com<br>> To: nlhintz@hotmail.com<br>> CC: noltari@gmail.com; openwrt-devel@lists.openwrt.org; hauke@hauke-m.de<br>> Subject: Re: [OpenWrt-Devel] [PATCH v4] brcm-wl: fix bash comparison error<br>> <br>> * Nathan Hintz <nlhintz@hotmail.com> [18.10.2014 22:24]:<br>> > Using the "\n" is not correct. I think the real problem is that the logic is reversed (should be && instead of ||); although it might<br>> > be better to eliminate the conditional entirely since leddc is always commanded to "0xffff" when the interface is taken down.<br>> > <br>> > local leddc=$(wlc ifname "$device" leddc)<br>> > [ "$leddc" = "0xffff" ] && {<br>> > leddc=0x005a000a<br>> > }<br>> <br>> what about:<br>> <br>> case "$leddc" in<br>> '0xffff'*)<br>> leddc='0x005a000a'<br>> ;;<br>> esac<br>> <br>> IMHO the approach from felix does not work:<br>> root@box:~ echo $((0xffff))<br>> 65535<br>> root@box:~ echo $((0xffff\n))<br>> -ash: arithmetic syntax error<br>> <br>> the real would be the fix the output of 'wlc'.<br><br>'wlc' is not broken, a simple test case demonstrates it works as expected:<br><br>root@e3000-1:~# wlc ifname wl0 leddc<br>0x005a000a<br>root@e3000-1:~# wlc ifname wl0 leddc 0xffff<br>root@e3000-1:~# wlc ifname wl0 leddc<br>0xffff<br>root@e3000-1:~# leddc=$(wlc ifname wl0 leddc)<br>root@e3000-1:~# [ "$leddc" = "0xffff" ] && echo yes<br>yes<br>root@e3000-1:~# wlc ifname wl0 leddc 0x005a000a<br>root@e3000-1:~# wlc ifname wl0 leddc<br>0x005a000a<br>root@e3000-1:~# leddc=$(wlc ifname wl0 leddc)<br>root@e3000-1:~# [ "$leddc" = "0xffff" ] && echo yes<br>root@e3000-1:~# <br><br>Nathan<br><br>> <br>> bye bastian<br></div> </div></body>
</html>