<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Rafał:<br><br><div>> Date: Sat, 18 Oct 2014 23:13:45 +0200<br>> Subject: Re: [PATCH] brcm47xx: move wrt610n_v2 and e3000_v1 to mips74k subtarget<br>> From: zajec5@gmail.com<br>> To: nlhintz@hotmail.com<br>> CC: openwrt-devel@lists.openwrt.org; hauke@hauke-m.de<br>> <br>> On 18 October 2014 22:37, Nathan Hintz <nlhintz@hotmail.com> wrote:<br>> ><br>> > Hi Rafał:<br>> ><br>> >> Date: Sat, 18 Oct 2014 21:28:29 +0200<br>> >> Subject: Re: [PATCH] brcm47xx: move wrt610n_v2 and e3000_v1 to mips74k<br>> >> subtarget<br>> >> From: zajec5@gmail.com<br>> >> To: nlhintz@hotmail.com<br>> >> CC: openwrt-devel@lists.openwrt.org; hauke@hauke-m.de<br>> ><br>> >><br>> >> On 18 October 2014 21:08, Nathan Hintz <nlhintz@hotmail.com> wrote:<br>> >> > - # BCMA SoC with SSB WiFi<br>> >> > - $(call Image/Build/CyberTAN,$(1),wrt610n_v2,610N,2.0.0,$(patsubst<br>> >> > jffs2-%,jffs2,$(1)))<br>> >> > - $(call Image/Build/CyberTAN,$(1),e3000_v1,61XN,1.0.3,$(patsubst<br>> >> > jffs2-%,jffs2,$(1)))<br>> >><br>> >> They are there for a reason and there is even a comment for that!<br>> ><br>> > Can you be more explicit as to why they are an exception?<br>> <br>> Same to you about commit messages ;)<br><br>I wasn't trying to be snarky; but that's OK. I'm just looking for info and to further the discussion. :-)<br><br>> <br>> <br>> > Neither are "SSB Wifi"<br>> <br>> They are.<br>> <br>> https://wikidevi.com/wiki/Linksys_WRT610N_v2<br>> BCM4322 which is SSB based<br>> <br>> https://wikidevi.com/wiki/Linksys_E3000<br>> BCM4322 which is SSB based<br>> <br><br>I see your point; however, the E3000 and WRT610Nv2 are mips74k, and would get the same<br>benefit from using the mips74k subtarget (mips32r2) as all of the others. The only difference<br>that I can see is that the E3000 and WRT610nV2 are required to use the proprietary<br>Broadcom wl driver (which is one of the supported profiles under the mips74k subtarget) in<br>order to utilize the 5GHz radio; whereas, with at least some of the others, using the proprietary<br>Broadcom wl driver is optional. I could modify the patch description to include this info and to<br>keep the "SSB Wifi" comment if you think it is necessary.<br><br>> <br>> > and I have<br>> > installed the mips74k trx with the broadcom_wl<br>> <br>> wl.ko doesn't use kernel ssb/bcma modules<br><br>Nathan<br></div> </div></body>
</html>