<div dir="ltr"><div><div><div>Resent with Signed-off-by tag.<br></div><div></div><br></div></div>Thanks<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 30, 2014 at 5:42 AM, Florian Fainelli <span dir="ltr"><<a href="mailto:florian@openwrt.org" target="_blank">florian@openwrt.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">2014-07-29 0:07 GMT-07:00 Alexandru Ardelean <<a href="mailto:ardeleanalex@gmail.com">ardeleanalex@gmail.com</a>>:<br>


<div class="">> ---<br>
>  openwrt/package/devel/valgrind/Makefile | 17 ++++++++++++-----<br>
>  1 file changed, 12 insertions(+), 5 deletions(-)<br>
<br>
</div>Your patch is missing a Signed-off-by tag, other than that, this looks<br>
good to me.<br>
<div><div class="h5"><br>
><br>
> diff --git a/openwrt/package/devel/valgrind/Makefile b/openwrt/package/devel/valgrind/Makefile<br>
> index 6c22348..a55fb40 100644<br>
> --- a/openwrt/package/devel/valgrind/Makefile<br>
> +++ b/openwrt/package/devel/valgrind/Makefile<br>
> @@ -28,7 +28,7 @@ include $(INCLUDE_DIR)/<a href="http://kernel.mk" target="_blank">kernel.mk</a><br>
>  define Package/valgrind<br>
>    SECTION:=devel<br>
>    CATEGORY:=Development<br>
> -  DEPENDS:=@mips||mipsel||i386||powerpc||arm_v7 +libpthread +librt<br>
> +  DEPENDS:=@mips||mipsel||i386||x86_64||powerpc||arm_v7 +libpthread +librt<br>
>    TITLE:=debugging and profiling tools for Linux<br>
>    URL:=<a href="http://www.valgrind.org" target="_blank">http://www.valgrind.org</a><br>
>  endef<br>
> @@ -77,13 +77,20 @@ define Package/valgrind/description<br>
>         to speed up and reduce memory use of your programs.<br>
>  endef<br>
><br>
> -CPU := $(patsubst x86,i386,$(LINUX_KARCH))<br>
> +CPU := $(patsubst x86_64,amd64,$(patsubst x86,i386,$(LINUX_KARCH)))<br>
><br>
>  CONFIGURE_VARS += \<br>
>         UNAME_R=$(LINUX_VERSION)<br>
><br>
> +ifeq ($(ARCH),x86_64)<br>
> +       BITS := 64bit<br>
> +else<br>
> +       CONFIGURE_ARGS += \<br>
> +               --enable-only32bit<br>
> +       BITS := 32bit<br>
> +endif<br>
> +<br>
>  CONFIGURE_ARGS += \<br>
> -       --enable-only32bit \<br>
>         --enable-tls \<br>
>         --without-x \<br>
>         --without-uiout \<br>
> @@ -101,8 +108,8 @@ define Package/valgrind/install<br>
>                 $(PKG_INSTALL_DIR)/usr/lib/valgrind/none-* \<br>
>                 $(PKG_INSTALL_DIR)/usr/lib/valgrind/vgpreload_core*.so \<br>
>                 $(PKG_INSTALL_DIR)/usr/lib/valgrind/$(CPU)-*.xml \<br>
> -               $(PKG_INSTALL_DIR)/usr/lib/valgrind/32bit-core*.xml \<br>
> -               $(PKG_INSTALL_DIR)/usr/lib/valgrind/32bit-linux*.xml \<br>
> +               $(PKG_INSTALL_DIR)/usr/lib/valgrind/$(BITS)-core*.xml \<br>
> +               $(PKG_INSTALL_DIR)/usr/lib/valgrind/$(BITS)-linux*.xml \<br>
>                 $(PKG_INSTALL_DIR)/usr/lib/valgrind/memcheck-* \<br>
>                 $(PKG_INSTALL_DIR)/usr/lib/valgrind/vgpreload_memcheck*.so \<br>
>                 $(1)/usr/lib/valgrind/<br>
> --<br>
> 1.8.4.5<br>
</div></div>> _______________________________________________<br>
> openwrt-devel mailing list<br>
> <a href="mailto:openwrt-devel@lists.openwrt.org">openwrt-devel@lists.openwrt.org</a><br>
> <a href="https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel" target="_blank">https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel</a><br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Florian<br>
</font></span></blockquote></div><br></div>