[PATCH] realtek: netgear_gs310tp-v1: Document UART location and pinout

[Uwe Kleine-König]

Hello Sander,

On 4/26/26 22:32, Sander Vanheule wrote:
> On Sun, 2026-04-26 at 18:44 +0200, Uwe Kleine-König wrote:
>> Signed-off-by: Uwe Kleine-König <uwe at kleine-koenig.org>
>> ---
>>  target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts
>> b/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts
>> index dd5993ad6a8e..8d5d589716ed 100644
>> --- a/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts
>> +++ b/target/linux/realtek/dts/rtl8380_netgear_gs310tp-v1.dts
>> @@ -1,5 +1,7 @@
>>  // SPDX-License-Identifier: GPL-2.0-or-later
>>  
>> +/* Console on &uart1. Exposed on J1 (opposide of the SFP cages), 2=RX, 3=TX,
>> 4=GND */
>> +
> 
> This is pretty much already described by the nodes in rtl838x.dtsi:
> 
> 	aliases {
> 		serial0 = &uart0;
> 	};
> 	chosen {
> 		stdout-path = "serial0:115200n8";
> 	};
> 
> Furthermore, the pinout is described in the message of commit c829bc1f2c3c
> ("realtek: Add support for Netgear S350 series switches GS308T and GS310TP")
> that originally added support for this device.

I find it more natural to look up this kind of information in the device
tree itself instead of the commit history. (And I in fact I only spotted
it after finding the pins myself when looking at the older commits
touching this file to choose who to send this patch to.) The upside of a
comment in the dts is that it's not set in stone but can be adapted over
time.

But I'm not very involved in OpenWrt development and if it's usual to
lookup such info in the originating commit, that's fine. (Though I'd
argue that on mainlining the device tree, such info would be welcome in
the dts.)

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20260426/5fd5c206/attachment.sig>