[PATCH] bcm53xx: Unconditionally build U-Boot for DIR-890L

[Rafał Miłecki]

On 2023-09-02 18:33, Linus Walleij wrote:
> Building the DIR-890L image requires U-Boot to be built
> so list it as a device package.
> 
> Reported-by: Arınç ÜNAL <arinc.unal at arinc9.com>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> Missed to enforce U-Boot build. Mea Culpa.
> ---
>  target/linux/bcm53xx/image/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/linux/bcm53xx/image/Makefile
> b/target/linux/bcm53xx/image/Makefile
> index 39b7efbef789..9483812facca 100644
> --- a/target/linux/bcm53xx/image/Makefile
> +++ b/target/linux/bcm53xx/image/Makefile
> @@ -283,7 +283,7 @@ TARGET_DEVICES += dlink_dir-885l
>  define Device/dlink_dir-890l
>    DEVICE_VENDOR := D-Link
>    DEVICE_MODEL := DIR-890L
> -  DEVICE_PACKAGES := $(BRCMFMAC_43602A1) $(USB2_PACKAGES) 
> $(USB3_PACKAGES)
> +  DEVICE_PACKAGES := uboot-bcm53xx $(BRCMFMAC_43602A1)
> $(USB2_PACKAGES) $(USB3_PACKAGES)
>    # Layout: U-boot (128kb max) followed by kernel and appended DTB.
>    # This is done because the boot loader will only read the first 2 MB
>    # from the flash and decompress the LZMA it finds there after the

This may work as a workaround (I didn't try it) but it doesn't seem like
a proper solution. DEVICE_PACKAGES should be used for listing packages
to be included in device's rootfs.

I don't see anything incorrect with Linus's original patch. Maybe we
just have some dependency handling issue in u-boot generic .mk code?
Is this issue bcm53xx specific? I think other targets use U-Boot in a
similar way.