[PATCH 06/20] kernel: remove drivers marked as modules

Elliott Mitchell ehem+openwrt at m5p.com
Wed Nov 15 14:44:19 PST 2023


On Wed, Nov 15, 2023 at 11:29:23AM +0100, Bjørn Mork wrote:
> Elliott Mitchell <ehem+openwrt at m5p.com> writes:
> 
> > Previously these would get built, then simply omitted from the
> > resultant image.
> 
> A kernel image built with a config symbol set to 'm' is sometimes
> deliberately differerent from an image built with the same symbol set
> to 'n'.  The kernel is sprinkled with IS_ENABLED() or similar open coded
> tests. Some of the symbols you are removing are tested.
> 
> Did you verify that all these changes still produce the same kernel
> images as before?

No, I haven't.  I would tend to look at the git log to find out why
those were added (no mention would suggest accident), but the git log
is rather troublesome for the config files.

I'll try to take a look, but right now I'm spending time testing the
split of kernel source and kernel build.  OpenWRT appears to have quite a
number of issues there.

If enabling those as modules helps then something is very wrong.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445





More information about the openwrt-devel mailing list