[PATCH] x86 64: Add new device Cordoba Edge Platform

[Philip Prindeville]

> On Oct 30, 2023, at 11:17 AM, Paul Spooren <mail at aparcar.org> wrote:
> 
> Hi,
> 
> We kind of don’t add image just to contain extra drivers. Extra UCI defaults for eth ordering are fine but please don’t add an extra image if it just contains 1-2 extra packages, installable via the ImageBuilder or OPKG.
> 
>> 
>>> On Oct 23, 2023, at 8:52 PM, Xiaojun Liu <xiaojun.liu at silicom.co.il> wrote:
>>> 
>>> Add new device Cordoba Edge Platform
>>> Device name:Cordoba Edge Platform
>>> hardware specifications: CPU - Intel Atom C3000
>>>                        WiFi - mt7915e
>>> 
>>> Signed-off-by: Xiaojun Liu mailto:xiaojun.liu at silicom.co.il
>>> ---
>>> 
>>> target/linux/x86/base-files/etc/board.d/02_network | 11 +++++++++++
>>> target/linux/x86/image/64.mk                       | 10 ++++++++++
>>> 2 files changed, 21 insertions(+)
>>> 
>>> 
>>> diff --git a/target/linux/x86/base-files/etc/board.d/02_network 
>>> b/target/linux/x86/base-files/etc/board.d/02_network
>>> index e00e8c04dd..be56153695 100644
>>> --- a/target/linux/x86/base-files/etc/board.d/02_network
>>> +++ b/target/linux/x86/base-files/etc/board.d/02_network
>>> @@ -75,6 +75,17 @@ traverse-technologies-geos)
>>>       macaddr="$(cat /sys/class/net/eth0/address)" 2>/dev/null
>>>       [ -n "$macaddr" ] && ucidef_set_interface_macaddr "wan" "$macaddr"
>>>       ;;
>>> +silicom-80500-0214-e53)
>>> +        ucidef_set_network_device_path "wan0" "pci0000:00/0000:00:16.0/0000:03:00.0"
>>> +        ucidef_set_network_device_path "wan1" "pci0000:00/0000:00:16.0/0000:03:00.1"
>>> +        ucidef_set_network_device_path "media0" "pci0000:00/0000:00:17.0/0000:02:00.0"
>>> +        ucidef_set_network_device_path "media1" "pci0000:00/0000:00:17.0/0000:02:00.1"
>>> +        ucidef_set_network_device_path "eth0" "pci0000:00/0000:00:0c.0/0000:04:00.0"
>>> +        ucidef_set_network_device_path "eth1" "pci0000:00/0000:00:0e.0/0000:05:00.0"
>>> +        ucidef_set_network_device_path "eth2" "pci0000:00/0000:00:0f.0/0000:06:00.0"
>>> +        ucidef_set_network_device_path "eth3" "pci0000:00/0000:00:10.0/0000:07:00.0"
>>> +        ucidef_set_interfaces_lan_wan "eth0 eth1 eth2 eth3" "wan0"
>>> +        ;;
>>> esac
>>> board_config_flush
>>> 
>>> diff --git a/target/linux/x86/image/64.mk 
>>> b/target/linux/x86/image/64.mk index 5ec9978b66..4addddeb98 100644
>>> --- a/target/linux/x86/image/64.mk
>>> +++ b/target/linux/x86/image/64.mk
>>> @@ -8,3 +8,13 @@ define Device/generic
>>>  GRUB2_VARIANT := generic
>>> endef
>>> TARGET_DEVICES += generic
>>> +
>>> +define Device/cordoba
>>> +  DEVICE_VENDOR := Cordoba
>>> +  DEVICE_MODEL := x86/64
>>> +  DEVICE_PACKAGES += \
>>> +        kmod-igc kmod-ixgbe \
>>> +        kmod-mt7915-firmware
>>> +  GRUB2_VARIANT := generic
>>> +endef
>>> +TARGET_DEVICES += cordoba
> 
> Please remove those lines in 64.mk.
> 
> Thanks for you work and interest in OpenWrt support for your device.
> 
> Best,
> Paul


I’m not sure I understand why.  Would you want someone to build the image and leave out the necessary drivers?  They’re more than just “extra packages”, they’re *essential* packages.

We have hundreds of profiles for other architectures, even different profiles for different versions of the same base design (like Archer C7).

Why are we so miserly when it comes to x86_64?

-Philip