[PATCH fstools v2] partname: Correct fstools_partname_fallback_scan comparison

Brian Norris computersforpeace at gmail.com
Fri Feb 3 10:27:30 PST 2023


Hi Ansuel (or others),

On Wed, Jan 25, 2023 at 10:18 PM Brian Norris
<computersforpeace at gmail.com> wrote:
>
> Commit 1ea5855e980c ("partname: Introduce fstools_partname_fallback_scan
> option") had two problems:
>
> 1. The strcmp() aborted when the param *matched* 1; we wanted the
>    inverse
> 2. It was too aggressive about skipping the fallback behavior. For
>    devices that had no root= parameter, they would always attempt the
>    fallback scan.
>
> Fix both of those.
>
> Fixes: 1ea5855e980c ("partname: Introduce fstools_partname_fallback_scan option")
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>

Would you be able to look at this soon? Your emergency fix broke
multiple things, and I'd like to get TP-Link OnHub back in shape so
others can rely on snapshot builds.

Thanks,
Brian



More information about the openwrt-devel mailing list