[PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L

Bjørn Mork bjorn at mork.no
Tue Aug 1 01:17:58 PDT 2023


Petr Štetiar <ynezz at true.cz> writes:
> Bjørn Mork <bjorn at mork.no> [2023-08-01 08:51:03]:
>
>> There's a "6 approving reviews" rule on github, and not
>> even close to that many active reviewers.  Sp adding new devices via
>> pull requests seems impossible at the moment.
>
> Thats done on purpose, due to the current git.openwrt.org based workflow,
> basically to prevent accidental merging via GH as this would break Git
> repository sync. AFAIK GH simply doesn't allow us to disable those merge
> buttons, so this is our workaround.

Well, OK.  But since there is no merging any other way, the impression
left to random developers passing by is that it's futile to send pull
requests.

Obviously not a precise count of requess ready to be merged, but IMHO
still an indication of the sorry state:
https://github.com/openwrt/openwrt/pulls?q=is%3Apr+is%3Aopen+%22add+support+%22

Now I know that reviewer resources ia s problem for all projects, so I
probably shouldn't whine about it.  But I do have a hard time
understanding the current OpenWrt workflow.



Bjørn



More information about the openwrt-devel mailing list