[PATCH] ipq40xx: 5.10: refresh config

Robert Marko robert.marko at sartura.hr
Sat Nov 6 16:50:41 PDT 2021


On Sun, Nov 7, 2021 at 12:26 AM Christian Lamparter <chunkeey at gmail.com> wrote:
>
> On 04/11/2021 16:17, Robert Marko wrote:
> > On Thu, Nov 4, 2021 at 4:15 PM Christian Lamparter <chunkeey at gmail.com> wrote:
> >>
> >> On 04/11/2021 12:53, Robert Marko wrote:
> >>> It looks like CONFIG_BLK_CMDLINE_PARSER was forgotten during the Orbi
> >>> device merge.
> >>> So lets refresh the config with it.
> >>
> >> Hmm, is it missing for 5.4 as well?! The generic 5.4 config doesn't
> >> enable it either.
> >
> > Honestly, I haven't checked 5.4 I stumbled upon this when enabling the
> > DSA driver combo.
>
> CONFIG_CMDLINE_PARTITION selects CONFIG_BLK_CMDLINE_PARSER.
> So that CONFIG_BLK_CMDLINE_PARSER is added during by the refresh, since
> it ends up enabled in the generated .config, while it's disabled in the
> generic 5.4/5.10 and it's not in config-filter. So no breakage.

Ok, its good that it was working fine before the refresh as well.
>
> (No, I didn't bother with refreshing ipq40xx's 5.4 config.
> I found something else when looking in ipq40xx/Makefile:
>
> KERNEL_PATCHVER:=5.10
> KERNEL_TESTING_PATCHVER:=5.10

This was previously a point of discussion, don't remember it leaning
in any direction.
Personally, I don't like keeping KERNEL_TESTING_PATCHVER if it's equal
to the default one.

Regards,
Robert
>
> o)
>
> Cheers,
> Christian



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko at sartura.hr
Web: www.sartura.hr



More information about the openwrt-devel mailing list