[PATCH] treewide: remove execute bit and shebang from board.d files

Ye Holmes yeholmes at outlook.com
Fri Feb 26 10:46:24 EST 2021


On Fri, 26 Feb 2021 14:52:07 +0100, Adrian Schmutzler wrote:
> Can somebody enlighten me what we achieve with the $() enclosing
> the sourcing command?

Compared to the results a moment ago, $(. XXX) does try to evaluate
output from XXX script:

root at OpenWrt:/# cat /tmp/source.sh
#!/bin/sh
$(. /tmp/hello.sh)
exit 9
root at OpenWrt:/# cat /tmp/hello.sh
#!/bin/sh
echo 'exit 8'
root at OpenWrt:/# sh /tmp/source.sh
root at OpenWrt:/# echo $?
8

Removing shebang from scripts without .sh suffix (such as
/etc/board.d/02_network), it would be difficult to highlight
the syntax automatically when opened with editors (e.g. Vim)
on host.



More information about the openwrt-devel mailing list