[OpenWrt-Devel] [PATCH] ppd: add missing header

[Petr Štetiar]

Rosen Penev <rosenp at gmail.com> [2020-03-29 21:44:34]:

> sys/cdefs.h is needed for __P macro definition.

Where? I mean, which combination triggers this issue? Perhaps upstream
material?

> Signed-off-by: Rosen Penev <rosenp at gmail.com>
> ---
>  package/network/services/ppp/Makefile                |  2 +-
>  package/network/services/ppp/patches/800-cdefs.patch | 10 ++++++++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
>  create mode 100644 package/network/services/ppp/patches/800-cdefs.patch
> 
> diff --git a/package/network/services/ppp/Makefile b/package/network/services/ppp/Makefile
> index 9e42cb7437..88b0a518e5 100644
> --- a/package/network/services/ppp/Makefile
> +++ b/package/network/services/ppp/Makefile
> @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
>  include $(INCLUDE_DIR)/kernel.mk
>  
>  PKG_NAME:=ppp
> -PKG_RELEASE:=2
> +PKG_RELEASE:=3
>  
>  PKG_SOURCE_PROTO:=git
>  PKG_SOURCE_URL:=https://github.com/paulusmack/ppp
> diff --git a/package/network/services/ppp/patches/800-cdefs.patch b/package/network/services/ppp/patches/800-cdefs.patch
> new file mode 100644
> index 0000000000..e361275a3c
> --- /dev/null
> +++ b/package/network/services/ppp/patches/800-cdefs.patch
> @@ -0,0 +1,10 @@
> +--- a/pppd/pppd.h
> ++++ b/pppd/pppd.h
> +@@ -53,6 +53,7 @@
> + #include <stdlib.h>		/* for encrypt */
> + #include <unistd.h>		/* for setkey */
> + #include <limits.h>		/* for NGROUPS_MAX */
> ++#include <sys/cdefs.h>		/* for __P */
> + #include <sys/param.h>		/* for MAXPATHLEN and BSD4_4, if defined */
> + #include <sys/types.h>		/* for u_int32_t, if defined */
> + #include <sys/time.h>		/* for struct timeval */
> -- 
> 2.25.1
> 
> 

-- 
ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel