[OpenWrt-Devel] [PATCH] malta: fix missing watchdog dependency in hwmon-sch5627

[Yousong Zhou]

On Thu, 5 Mar 2020 at 20:43, Petr Štetiar <ynezz at true.cz> wrote:
>
> Yousong Zhou <yszhou4tech at gmail.com> [2020-03-05 19:56:40]:
>
> > > Fixes following error uncovered while building malta/be on 5.4:
> > >
> > >  Package kmod-hwmon-sch5627 is missing dependencies for the following libraries:
> > >  watchdog.ko
> > >
> > > That dependency was introduced in upstream via 2d8c7ff52c24
> > > ("hwmon/sch56xx: Depend on watchdog for watchdog core functions") in
> > > v3.5.
> >
> > Does it make we actually package watchdog.ko as a module?
>
> The proposed patch adds that watchdog core as built-in, that missing dependency
> error is probably misleading, having that watchdog core built-in is good
> enough.
>
> -- ynezz

My concern is still on image size which malta can't care less as we
mostly (if not always) run it as qemu virtual machine.

As for other targets, if it's just kmod-hwmon-sch5627, we should
package watchdog.ko separately instead of making it kernel builtin, to
save space.

Regards,
                yousong

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel