[OpenWrt-Devel] olsrd: not compiling with gcc 9

Sven Roederer devel-sven at geroedel.de
Sun Jun 7 17:51:06 EDT 2020


Am Sonntag, 7. Juni 2020, 23:39:08 CEST schrieb Rosen Penev:
> > Le 7 juin 2020 à 1:38 PM, Nick <vincent at systemli.org> a écrit :
> > 
> > I would suggest doing this PR as patch like freifunk berlin is doing it:
> > https://github.com/freifunk-berlin/firmware/commit/93f9a026e025c7b663369f5
> > 284cec0bb91345220
> Someone needs to propose one then.
> 

This patch was referenced by an issue (https://github.com/openwrt-routing/
packages/issues/547#issuecomment-586213155), but original author was not
able to runtime-test. In Freifunk Berlin we also don't use the pud-plugin and
can't therefore not confirm it.

> > Otherwise, olsrd won't compile anymore. :/ Or making a fork, because
> > olsrd seems not to be maintained anymore.
> > 

I just opened PR #575 to mark this package as broken, till there is a 
maintainer again ...

Sven

> >> On 07.06.20 22:27, Nick wrote:
> >> Here is a PR that is fixing the issue. Why is that not merged? :/
> >> 
> >> https://github.com/OLSR/olsrd/pull/79/files
> >> 
> >> On 07.06.20 22:03, Rosen Penev wrote:
> >>>> Le 7 juin 2020 à 1:00 PM, Nick <vincent at systemli.org> a écrit :
> >>>> 
> >>>> I can not compile olsrd daemon with gcc9.
> >>>> 
> >>>>> #define isNaN(x) (x != x)
> >>>>> ...
> >>>>> if (!isNaN(gpsdata->fix.time)) {
> >>>> 
> >>>> Here fix.time is a struct timespec.
> >>>> The call is just wrong, or? Why should I check a struct for a valid
> >>>> float?
> >>> 
> >>> This broke when gpsutils got updated. API change with libgps.
> >>> 




_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list