[PATCH 1/1] sysupgrade need fwtool over the next stages to remove the metadata info for UBI volumes. This patch creates copy of /usr/bin/fwtool to /tmp directory to preserves it after the sysupgrade ramdisk switch. Later fwtool is being referenced from platform.sh script for device specific metadata removal

Rafał Miłecki zajec5 at gmail.com
Thu Jul 23 08:28:36 EDT 2020


On Mon, 20 Jul 2020 at 21:15, Todor Colov <todorcolov at abv.bg> wrote:
> Signed-off-by: Todor Colov <todorcolov at abv.bg>

You put the whole commit message as the subject. Please use a short
subject message + proper description.


> @@ -36,7 +36,9 @@ fwtool_check_image() {
>                 }
>                 [ "$REQUIRE_IMAGE_METADATA" = 1 ] && return 1
>                 return 0
> -       fi
> +       fi
> +       # keep fwtool copy in /tmp for later reference from platform.sh for device specific metadata removal
> +       cp /usr/bin/fwtool /tmp/.
>
>         json_load "$(cat /tmp/sysupgrade.meta)" || {
>                 echo "Invalid image metadata"

1. Random white spaces after "fi"
2. Could RAMFS_COPY_BIN be used instead?

-- 
Rafał



More information about the openwrt-devel mailing list