[PATCHv2 4/4] scripts/clean-package.sh: switch from -a in if to &&

Rosen Penev rosenp at gmail.com
Sat Jul 11 14:45:28 EDT 2020


-a is not well defined.

Signed-off-by: Rosen Penev <rosenp at gmail.com>
---
 v2: rebased
 scripts/clean-package.sh | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
index 03e49df3e7..ccbb486eea 100755
--- a/scripts/clean-package.sh
+++ b/scripts/clean-package.sh
@@ -1,13 +1,14 @@
 #!/usr/bin/env bash
 IFS=$'\n'
-[ -n "$1" -a -n "$2" ] || {
+
+if [ -z "$1" ] || [ -z "$2" ]; then
 	echo "Usage: $0 <file> <directory>"
 	exit 1
-}
-[ -f "$1" -a -d "$2" ] || {
+fi
+if [ ! -f "$1" ] || [ ! -d "$2" ]; then
 	echo "File/directory not found"
 	exit 1
-}
+fi
 (
 	cd "$2" || exit 1
 	while read -r entry; do
-- 
2.26.2




More information about the openwrt-devel mailing list