[OpenWrt-Devel] [PATCH 2/2] rssileds: restrict package to targets where it is used

[Piotr Dymacz]

Hi Adrian,

On 20.02.2020 19:00, Adrian Schmutzler wrote:
>> -----Original Message-----
>> From: Piotr Dymacz [mailto:pepe2k at gmail.com]
>> Sent: Donnerstag, 20. Februar 2020 18:58
>> To: Adrian Schmutzler <freifunk at adrianschmutzler.de>; openwrt-
>> devel at lists.openwrt.org
>> Subject: Re: [OpenWrt-Devel] [PATCH 2/2] rssileds: restrict package to targets
>> where it is used
>> 
>> Hi Adrian,
>> 
>> On 20.02.2020 18:52, Adrian Schmutzler wrote:
>> > It does not seem very sensible to provide the rssileds package
>> > on targets without corresponding LEDs, so restrict it to the
>> > targets where it is used at the moment.
>> 
>> This package isn't hardware related and shouldn't be limited to targets
>> where only officially supported devices make use of it.
>> 
>> Thus, NAK from me for this one.
> 
> I assume that's only for 2/2?

Yes, only this one (patch).

-- 
Cheers,
Piotr

> 
>> 
>> --
>> Cheers,
>> Piotr
>> 
>> >
>> > Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
>> > ---
>> >   package/network/utils/rssileds/Makefile | 2 +-
>> >   1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/package/network/utils/rssileds/Makefile
>> b/package/network/utils/rssileds/Makefile
>> > index 7a59314693..c8e8f39de9 100644
>> > --- a/package/network/utils/rssileds/Makefile
>> > +++ b/package/network/utils/rssileds/Makefile
>> > @@ -18,7 +18,7 @@ define Package/rssileds
>> >     SECTION:=net
>> >     CATEGORY:=Network
>> >     TITLE:=RSSI real-time LED indicator
>> > -  DEPENDS:=+libiwinfo +libnl-tiny +libubox +libuci
>> > +  DEPENDS:=@(TARGET_ar71xx||TARGET_ath79||TARGET_ramips) +libiwinfo
>> +libnl-tiny +libubox +libuci
>> >     MAINTAINER:=Daniel Golle <dgolle at allnet.de>
>> >   endef
>> >
>> >
> 
> 


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel