[OpenWrt-Devel] [PATCH 3/3] ramips: rearrange LEDs for ZBT-WE826 devices to prevent delete-node

Petr Štetiar ynezz at true.cz
Fri Sep 20 02:55:49 EDT 2019

Adrian Schmutzler <freifunk at adrianschmutzler.de> [2019-09-17 14:22:23]:


> So far, for the ZBT-WE826-E the leds pulled from the DTSI are deleted and
> then redefined. The config in the DTSI is then used in two other DTSes for
> the ZBT-WE826 flash variants.
> Since the block is effectively only used for two devices, this moves led
> definitions to the device DTSes to prevent the use of delete-node.  This
> seems more logical than created the config and then deleting it again.

maybe, but I would prefer to keep the current state as it avoids copy&pasting
of the exactly same leds node to the two places.

>  4 files changed, 42 insertions(+), 23 deletions(-)

You've just added 21 more lines one would need to maintain.

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list