[OpenWrt-Devel] [ramips] Linkit Smart 7688 kmod-sdhci-mt7620

Ivan Hörler ivanhoerler at gmail.com
Sun Sep 15 07:00:03 EDT 2019


again from not DMARC rejected google account. see below. thanks

> Am 15.09.2019 um 12:57 schrieb Ivan Hörler via openwrt-devel <openwrt-devel at lists.openwrt.org>:
> 
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
> 
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.
> Von: Ivan Hörler <i.hoerler at me.com>
> Betreff: [OpenWrt-Devel] [ramips] Linkit Smart 7688 kmod-sdhci-mt7620
> Datum: 15. September 2019 um 12:57:33 MESZ
> An: Adrian Schmutzler <mail at adrianschmutzler.de>
> Kopie: openwrt-devel at lists.openwrt.org
> 
> 
> Hi Adrian
> So i did: https://github.com/openwrt/openwrt/pull/2411 <https://github.com/openwrt/openwrt/pull/2411>
> Thanks for the help!
> Ivan
> 
>> Am 14.09.2019 um 22:18 schrieb Adrian Schmutzler <notifications at github.com <mailto:notifications at github.com>>:
>> 
>> Hi, thanks for implementing my suggestions. However, please do not open a new PR when doing changes, but rebase your commits in the existing branch in the future, so discussion etc. is kept.
>> 
>> For this PR, I would like you to address the following minor issues:
>> 
>> You are changing only Linkit Smart 7688, but your commit title does not express that. Maybe choose something more specific like
>> "ramips: add SD-Card support to Linkit Smart 7688"
>> In the commit description, please remove the reference to 18.06. Your commit will be applied to master, and then might be backported to older stable branches, so the reference to 18.06 is wrong in this case. Just state that the SD-Card reader is not working ATM.
>>>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub <https://github.com/openwrt/openwrt/pull/2411?email_source=notifications&email_token=ABOOK6AQOMK3SJDOVHP3RYLQJVBIBA5CNFSM4IWXLNB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XDHMY#issuecomment-531510195>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOOK6G5BUMN6F2ZTLJ2OPLQJVBIBANCNFSM4IWXLNBQ>.
>> 
> 
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190915/fff8c81a/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list