[OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

[Rafał Miłecki]

On 2019-09-06 15:05, Adrian Schmutzler wrote:
>> diff --git a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh 
>> b/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh
>> index e313562017..8e02186eb8 100644
>> --- a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh
>> +++ b/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh
>> @@ -74,7 +74,7 @@ platform_do_upgrade_openmesh() {
>>  	#
>> 
>>  	# take care of restoring a saved config
>> -	[ "$UPGRADE_OPT_SAVE_CONFIG" -eq 1 ] && 
>> restore_backup="${MTD_CONFIG_ARGS} -j ${UPGRADE_BACKUP}"
>> +	[ -n "$UPGRADE_BACKUP" ] && restore_backup="${MTD_CONFIG_ARGS} -j 
>> ${UPGRADE_BACKUP}"
> 
> Any reason for the curly braces here?
> 
> If not, I'd consider removing them with this patch ...

I just left existing coding style

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel