[OpenWrt-Devel] [PATCH 1/2] ath79: add support for Netgear WNDR4300

[Michal Cieslakiewicz]

On Fri, 11 Oct 2019 12:20:04 +0200
"Adrian Schmutzler" <mail at adrianschmutzler.de> wrote:

Hello Adrian,

> Hi,
> 
> just some MAC related comments below:
> 
> > @@ -403,6 +404,10 @@ ath79_setup_macs()
> >  	netgear,wndr3800)
> >  		lan_mac=$(macaddr_setbit_la "$(mtd_get_mac_binary
> > art 0x0)") ;;
> > +	netgear,wndr4300)
> > +		lan_mac=$(mtd_get_mac_binary caldata 0x0)
> > +		wan_mac=$(mtd_get_mac_binary caldata 0x6)
> > +		;;  
> 
> lan_mac should be removed here. You already set mtd-mac-address in
> dts.
> 
Thanks, I'll fix it.

> > +&wmac {
> > +	status = "okay";
> > +
> > +	mtd-mac-address = <&art 0x0>;
> > +	qca,no-eeprom;
> > +};
> > +
> > +&pcie {
> > +	status = "okay";
> > +
> > +	ath9k: wifi at 0,0 {
> > +		compatible = "pci168c,0033";
> > +		reg = <0x0000 0 0 0 0>;
> > +		mtd-mac-address = <&art 0xc>;  
> 
> This order of addresses looks a litte uncommon. Have you verified it
> against stock firmware?
> 
> lan art 0x0
> wan art 0x6
> 2.4 GHz art 0x0
> 5 GHz art 0xc
> 
I can confirm this layout is identical to both stock firmware and
ar71xx version.

> Have you checked that there are no usable addresses in 0x1002 and
> 0x5006?
> 
Yes, there are wireless addresses inside calibration data at offsets you
provided, and they are both equal to LAN MAC.

Best regards
Michal

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel