[OpenWrt-Devel] [PATCH 2/3] tools/pkgconf: Run pkg-config wrapper through shellcheck

Petr Štetiar ynezz at true.cz
Thu Nov 28 08:30:05 EST 2019

Rosen Penev <rosenp at gmail.com> [2019-11-27 16:18:10]:

> > Switched to calling by dirname so that it can be called from any
> > directory.

I can see that already from the source code, but I would rather see a answer
to "Why?" In other words, whats the problem with current state, why is this
change needed?

> AGH. This is totally wrong. I goofed while rebasing this. It should
> have a / after dirname.

I would prefer to drop this change unless there is a good reason to have it.
It's not related to the patch subject in any way.

> Should I resend?

Yes please.

-- ynezz

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list