[OpenWrt-Devel] [PATCH] treewide: remove dts-v1 identifier from DTSI files

mans0n mans0n at gorani.run
Mon Nov 25 11:33:21 EST 2019

Hi Adrian,

I already read your previous mail two weeks ago, but then I was not very 
familiar with these mailing list stuff (still I am). Sorry for the late 

On 19. 11. 25. 6:53 AM, Adrian Schmutzler wrote:
 > The "/dts-v1/;" identifier is supposed to be put once at the beginning
 > of a device tree file. Thus, it makes no sense to provide it a second
 > time in to-be-included DTSI files.

Three months ago I was totally on your side, but while preparing for my 
A3 PR, I noticed two things:

1. The kernel also has (quite many) DTSI files with "/dts-v1/;". I'm not 
sure if this is intentional or also a mistake.
2. AFAIK documentation does not prohibit DTSI files with "/dts-v1/;". 
And DTSI files in OpenWrt follow v1 syntax (and not v0 nor non-existent 
v2), so I thought it would be better to clarify that. I'm not sure if 
it's okay if the version of DTS file is different from that of DTSI 
file, though.

That's why I included "/dts-v1/;" in mt7628an_iptime.dtsi. I don't have 
any objection to this patch, I just wanted to leave a comment on this issue.


openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list