[OpenWrt-Devel] [PATCH v2] ath79: use gpio_hog instead of gpio-export

Adrian Schmutzler mail at adrianschmutzler.de
Wed Nov 6 10:47:16 EST 2019


> Wouldn't it make more sense to spend time now on implementing
> future-proof solution and switch to it when it's ready?

Obviously, yes. But for the meantime, I'd like to have a less-arbitrary status quo.

> I believe the major issue here is that there is no 'in place'
> replacement for 'gpio-export' (or I'm just not aware of it).
> Are there any other reasons to get rid of 'gpio-export' _now_, other
> than the fact upstream rejected this approach?
> '03_gpio_switches' doesn't handle inputs.
> Of course, it has advantages, like the fact it makes the GPIO setup
> uci-based but on the other hand... it does its job fairly late during
> bootup. In some cases, you might want to, for example, enable power for
> 3/4G modem as early as possible, to give it time to register in network.
> Anyway, under the hood, it's the same approach, export named GPIO using
> _deprecated_ sysfs. Excluding uci and place in boot time where it
> happens, the difference is where the GPIOs are defined, DTS vs.
> user-space scripts.

So, both 03_gpio_switches and gpio-hogs provide less functionality than gpio-exports with no striking benefit. From that point of view we should actually allow gpio-exports in device support submissions again, and actually discourage gpio_hogs for the status quo ... (and it would be better to convert hogs to exports and not the other way around ...)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191106/036624a5/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list