[OpenWrt-Devel] [PATCH v2] ath79: use gpio_hog instead of gpio-export

Adrian Schmutzler mail at adrianschmutzler.de
Tue Nov 5 14:10:24 EST 2019


> -----Original Message-----
> From: Bjørn Mork [mailto:bjorn at mork.no]
> Sent: Dienstag, 5. November 2019 20:01
> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> Cc: openwrt-devel at lists.openwrt.org; 'Birger Koblitz' <mail at birger-koblitz.de>
> Subject: Re: [OpenWrt-Devel] [PATCH v2] ath79: use gpio_hog instead of gpio-
> export
> "Adrian Schmutzler" <mail at adrianschmutzler.de> writes:
> > But, based on the discussion here, the opposite has been identified as
> > superior solution (discussing nand subtarget):
> > https://github.com/openwrt/openwrt/pull/2184#discussion_r342136635
> That's missing the point. Regulators are superior if there is
> controlling driver. E.g.
> https://www.kernel.org/doc/Documentation/devicetree/bindings/usb/usb-nop-
> xceiv.txt
> See arch/arm/boot/dts/armada-385-linksys.dtsi for a nice, OpenWrt
> relevant, example using this with a fixed regulator.
> If you don't link anything to the regulator, then I agree that you might
> as well use gpio-hog.  But I still don't see how you can call that a
> superior solution.  It doesn't suck more or less.  I thought the ath79
> conversion was all about using devicetree to document the boards ;-)

Maybe "superior" was wrong here, as in the linked discussion the argument was that both are comparable, but gpio-hog requires less space.

For the content of this patch, I just want to get rid of gpio-export. So, for the moment I think the gpio-hog is an improvement over gpio-export.

Based on that, I'd be happy if someone would be willing to transition to an even better solution. :-)

No offense, but I aim at the low-hanging fruit for this one.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191105/06056cec/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list