[OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"

Jo-Philipp Wich jo at mein.io
Fri Nov 1 05:21:19 EDT 2019



> Removing this directory from TARGET_CPPFLAGS will cut down the log noise
> a bit. Not only will CPPFLAGS be shorter, there will be less warnings
> set off by "-Wmissing-include-dirs" (or even failures when paired with
> "-Werror"). After all the directory does not even _exist_ in the SDKs,
> which are used on the build bots when building packages (see [1] and
> [2]).


> Signed-off-by: Sebastian Kemper <sebastian_ml at gmx.net>

Acked-by: Jo-Philipp Wich <jo at mein.io>

I wanted to look into this for a long time but never had the motivation
to actually do comprehensive tests of the impacts of the removal.

So, thanks for looking into that - its fine from my side.

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191101/2b90bfac/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list