[OpenWrt-Devel] [PATCH 1/2] gpio-button-hotplug: support interrupt properties

Rosen Penev rosenp at gmail.com
Fri May 31 14:20:03 PDT 2019


On Thu, May 30, 2019 at 8:09 AM Christian Lamparter <chunkeey at gmail.com> wrote:
>
> Hello,
>
> On Thursday, May 30, 2019 12:00:27 PM CEST Petr Štetiar wrote:
> > Christian Lamparter <chunkeey at gmail.com> [2019-05-29 21:58:29]:
> > > Upstream Linux's input gpio-keys driver supports
> > > specifying a external interrupt for a gpio via the
> > > 'interrupts' properties as well as having support
> > > for software debounce.
> >
> > [...]
> >
> > I've just checked this on ath79 (archer-c7-v5) and on ramips/mt7620
> > (bdcom,wap2100-sk) with WPS buttons.
> >
> > Acked-by: Petr Štetiar <ynezz at true.cz>
>
> Can you tell me what you tested? Was it the software debounce?
> Because this should be the only bit that will affect the ath79
> platform I think (since it already has support for interrupts
> through the gpio controller).
>
> From what I can tell, ramips should use gpio-keys-polled exclusivly
> for now. This is because the rt2880-pinmux driver doesn't implement
> and irq support (though some of the chips should support it).
> all gpio-keys-polled should work as before.
The upstream driver fixes this. See

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/gpio/gpio-mt7621.c?h=v4.19.47
>
> Cheers,
> Christian
>
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list