[OpenWrt-Devel] [PATCH 2/2] procd: add notification if running in container

Paul Spooren mail at aparcar.org
Thu May 23 04:38:52 PDT 2019


On 5/23/19 10:42 AM, Petr Štetiar wrote:
> Paul Spooren <mail at aparcar.org> [2019-05-22 19:24:19]:
>
>> Signed-off-by: Paul Spooren <mail at aparcar.org>
>> ---
>>  state.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/state.c b/state.c
>> index ff1734f..9f196ee 100644
>> --- a/state.c
>> +++ b/state.c
>> @@ -101,6 +101,9 @@ static void state_enter(void)
>>  	switch (state) {
>>  	case STATE_EARLY:
>>  		LOG("- early -\n");
>> +		if (is_container())
>> +			LOG("This isn't real life. I'm running in a container.\n");
> your commit message is missing (it's required BTW), so I don't know the reason
> why do you need this change. 
I can amend the patch if it's of interest.
> Anyway, I don't see any valid reason to have
> this in procd.

My motivation was to log when procd detects a container and therefore
don't mount stuff. Anyway, if it bloats the log, reject this patch.

Best,
Paul




More information about the openwrt-devel mailing list