[OpenWrt-Devel] [PATCH] upgrade: nand: fix board_name assumtions

Bjørn Mork bjorn at mork.no
Tue May 21 10:44:48 PDT 2019


Petr Štetiar <ynezz at true.cz> writes:

> Jeff Kletsky <lede at allycomm.com> [2019-05-20 20:42:16]:
>
>> Having spent quite a bit of time today thinking about the impact of
>> board-name changes, I can see use cases where the running system doesn't
>> know a priori what the range of acceptable tar-dir values are.
>
> Well it makes me wonder, why you just don't do following:
>
>  platform_check_image() { 
> 	return 0
>  }
>
> As the image is already checked with fwtool_check_image metadata based check
> which should be probably good enough in order to lift any other additional
> checks. Of course, just in case your platform has enabled metadata checking,
> which in case of ath79 is true.

Doh! And the ramips target, which I've been messing with locally, did
that a long time ago.  I just didn't notice.  Guess I can just drop this
silently then.  Sorry about the noise.


Bjørn



More information about the openwrt-devel mailing list