[OpenWrt-Devel] [PATCH] lua: lnum: fix strtoul based number parsing

Karl Palsson karlp at tweak.net.au
Tue May 21 03:01:38 PDT 2019


Petr Štetiar  <ynezz at true.cz> wrote:
> From: Liangbin Lian <jjm2473 at gmail.com>
> 
> Lua's LNUM patch currently doesn't parse properly certain
> numbers as it's visible from the following simple tests.
> 


Tested-by: Karl Palsson <karlp at etactica.com>

This makes some busted unit tests of ours pass for the first time
on the openwrt target itself :) It will also mean we can drop
some places where we use "0x40000000 * 2" instead of the more
understandable 0x80000000 form :) (We've had problems with lnum
and reading arrays of 16bit numbers into various 32bit
singed/unsigned floating point forms in the past)

Sincerely,
Karl Palsson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP-digital-signature.html
Type: application/pgp-signature
Size: 1175 bytes
Desc: OpenPGP Digital Signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190521/1c699240/attachment.sig>


More information about the openwrt-devel mailing list