[OpenWrt-Devel] [PATCH v2] gemini: Support sysupgrade on DIR-685

Petr Štetiar ynezz at true.cz
Tue May 14 14:55:07 PDT 2019


Linus Walleij <linus.walleij at linaro.org> [2019-05-14 21:33:48]:

> The full header format can be seen in tools/firmware-utils/src/mkwrggimg.c
> and includes a MD5 digest. This MD5 digest is checked by the ROM
> of the machine every time it boots.

Ok, but if I understand it properly, if this ROM check fails (corrupted image
after the header and before the footer), then you need UART recovery anyway,
right?

> I guess I could insist on writing a utility in C to check that custom
> MD5 sum before we flash, it has a nice "being close to what the target
> wants" feeling about it.

It seems to me, that the appropriate place for this feature would be
fwtool/metadata as other platforms could benefit from this improved and
checksum based image checking as well.

> But on the other hand it could be nice that it is done
> according to the OpenWrt standard, and what really matters is that
> some checksum is checked, so I guess I will go with your suggestion
> unless the DAP-2695 A1 people have some other opinion?

Don't take me wrong, you should know this device better then I do, so if
you're really convinced, that this additional check is needed or such, well
then just keep it.

Anyway, if you take a look at all other platforms with
REQUIRE_IMAGE_METADATA=1, you'll probably find out, that metadata check is
good enough on most of them (all of them?) and platform_check_image usually
boils down to just more or less simple `return 0` on those platforms.

-- ynezz



More information about the openwrt-devel mailing list