[OpenWrt-Devel] [PATCH v2 2/2] procd: apply official kernel clang-format style

Paul Spooren mail at aparcar.org
Tue May 14 09:51:55 PDT 2019


On 5/14/19 6:24 PM, Daniel Golle wrote:
> I don't think adding formatter-information into the code makes sense
> at this stage, as this is meant for exeptions from an otherwise applied
> style. Here, obviously clang-format defintions don't reflect the
> current style.

They don't, they reflect the kernels style (at lest, as much as I
understand using the .clang-configuration file). If it's ugly, it's not
a matter of clang-format but of the kernels code style, not?

To not spam this list to much, I pushed two branches to GitHub with
default style:

clang-format-7 default:
https://github.com/aparcar/procd/commit/ad7a052dad6f0f6a7e429dc3c7bac4206280aafd

clang-format-9 default:
https://github.com/aparcar/procd/commit/fca19bb9c0d14e7da80dd9248e4dc75eedee8dc7

I'd be happy if you could give this a few minutes and send a config you
like:
https://zed0.co.uk/clang-format-configurator/

Sunshine,
Paul





More information about the openwrt-devel mailing list