[OpenWrt-Devel] [PATCH] ath79: Add missing read-only properties

Petr Štetiar ynezz at true.cz
Thu May 9 06:04:04 PDT 2019


Adrian Schmutzler <mail at adrianschmutzler.de> [2019-05-09 14:52:11]:

> > as ath79 has `DEFAULT_PACKAGES += uboot-envtools` and just few devices set
> > `DEFAULT_PACKAGES -= uboot-envtools` I would assume, that it's expected to
> > be
> > writeable.
> 
> Okay. I also found some devices where u-boot-env IS read-only, e.g.
> https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/dts/ar7240_buffalo_whr-g301n.dts#L131
> 
> What would you suggest:
>
> 1. Remove read-only from the remaining ones
> 2. Set it based on how DEFAULT_PACKAGES is set

even if you remove uboot-envtools from the base image, due to the flash space
constraints for example, the user is still able to post-install this package,
so we can't probably base our decision on the content of DEFAULT_PACKAGES
variable.

> 3. Don't change. Leave it as it was set by the submitters

Probably this option unless we've strong reason to do otherwise.

-- ynezz



More information about the openwrt-devel mailing list