[OpenWrt-Devel] [PATCH] ath79: Add missing read-only properties

Adrian Schmutzler mail at adrianschmutzler.de
Thu May 9 05:52:11 PDT 2019


Hi,

> -----Original Message-----
> From: Petr Štetiar [mailto:ynezz at true.cz]
> Sent: Donnerstag, 9. Mai 2019 14:42
> To: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> Cc: openwrt-devel at lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH] ath79: Add missing read-only properties
> 
> Adrian Schmutzler <freifunk at adrianschmutzler.de> [2019-05-09 13:50:39]:
> 
> Hi,
> 
> > The read-only properties for non-firmware partitions seem to have been
> > assigned rather randomly.
> 
> Instead of randomly I would say, that it was developer/submitter preference.
> 
> >  				label = "u-boot-env";
> > +				read-only;
> >  			};
> 
> as ath79 has `DEFAULT_PACKAGES += uboot-envtools` and just few devices set
> `DEFAULT_PACKAGES -= uboot-envtools` I would assume, that it's expected to
> be
> writeable.

Okay. I also found some devices where u-boot-env IS read-only, e.g.
https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/dts/ar7240_buffalo_whr-g301n.dts#L131

What would you suggest:
1. Remove read-only from the remaining ones
2. Set it based on how DEFAULT_PACKAGES is set
3. Don't change. Leave it as it was set by the submitters

In case 1 or 2, I would separate this from the other changes into a separate patch.

Best

Adrian

> 
> >  				label = "art";
> > +				read-only;
> >  			};
> 
> this one seems legit and should be probably ok.
> 
> -- ynezz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190509/b6d6df29/attachment.sig>


More information about the openwrt-devel mailing list