[OpenWrt-Devel] [PATCH] ath79: Add missing read-only properties

Petr Štetiar ynezz at true.cz
Thu May 9 05:41:38 PDT 2019


Adrian Schmutzler <freifunk at adrianschmutzler.de> [2019-05-09 13:50:39]:

Hi,

> The read-only properties for non-firmware partitions seem to have been
> assigned rather randomly.

Instead of randomly I would say, that it was developer/submitter preference.

>  				label = "u-boot-env";
> +				read-only;
>  			};

as ath79 has `DEFAULT_PACKAGES += uboot-envtools` and just few devices set
`DEFAULT_PACKAGES -= uboot-envtools` I would assume, that it's expected to be
writeable.

>  				label = "art";
> +				read-only;
>  			};

this one seems legit and should be probably ok.

-- ynezz



More information about the openwrt-devel mailing list