[OpenWrt-Devel] [PATCH] zynq: add manufactured to device title
luaraneda at gmail.com
Mon May 6 05:59:27 PDT 2019
Thanks for reviewing.
On Fri, May 3, 2019 at 8:26 AM Petr Štetiar <ynezz at true.cz> wrote:
> your changes, doesn't correspond with the commit description, see bellow.
You're right, the commit is doing more than just adding the
manufacturer. I thought that I could group such small changes but I
forgot to add them to the commit title/message.
> why are you removing the development part? I think, that it's useful
> information so it shouldn't be removed if you don't have a good reason for
> this. Putting appart the fact, that it's marked as trainer board on the
> vendor's site.
I'm proposing to remove the development part to make the title
consistent with all devices on the zynq target. The all are
My opinion is that using the manufacturer and the model is enough to
uniquely identify a device, and additional information belongs on the
wiki, as it doesn't help to identify a device on menuconfig. We can
even remove the "board" part of their title (with the same argument).
Look at the "Compex WPJ428", "QCA AP-DK01.1-C1" and "QCA AP-DK04.1-C1"
from the ipq40xx target, or the "BeagleBone" from the omap target.
They are a mix of development boards, reference designs, and embedded
boards, but none of that information is on their title.
Additionally, only 4 OpenWRT "devices" have the word "development" on
their title, and around 20 the word "reference".
Having said that, I really care about the manufacturer being added to
the title, and for consistency reasons, I propose one of these
1: Remove the development part (modify 2 boards, this patch)
2: Remove the development board part (modify 4 boards, new patch)
3: Add the development/trainer/evaluation part (modify 2 boards, new patch)
I'm now more inclined to go for option 2 and drop everything that's
not part of the manufacturer and model, as the "board" part is not
adding meaningful information from a developer point of view, IMHO.
I'll wait for your reply before sending a V2.
More information about the openwrt-devel