[OpenWrt-Devel] [PATCH] mac80211: rt2x00: fix crash on release_firmware

Kristian Evensen kristian.evensen at gmail.com
Tue Feb 26 02:54:04 EST 2019


Hi Stanislaw,

On Sun, Feb 24, 2019 at 10:23 AM Stanislaw Gruszka <sgruszka at redhat.com> wrote:
>
> Fix crash due to passing invalid r2x00dev->eeprom_file pointer to
> release_firmware(). Since we copy eeprom data with EEPROM_SIZE
> in rt2800_read_eeprom() we can use eeprom_file->size as marker
> if the file was crated by request_firmware().
>
> Cc: Felix Fietkau <nbd at nbd.name>,
> Cc: Daniel Golle <daniel at makrotopia.org>
> Signed-off-by: Stanislaw Gruszka <sgruszka at redhat.com>

Thanks for the patch. I submitted a patch doing something similar some
days ago, but your fix is much nicer. FWIW:

Acked-by: Kristian Evensen <kristian.evensen at gmail.com>

BR,
Kristian

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list