[OpenWrt-Devel] [PATCH 00/10] Stable material from OpenWrt

Greg Kroah-Hartman gregkh at linuxfoundation.org
Thu Feb 14 05:42:06 EST 2019


On Thu, Feb 14, 2019 at 11:24:26AM +0100, Linus Walleij wrote:
> This is a series of patches used in OpenWrt's v4.9 backports
> that seem to be of generic interest to v4.9.y
> 
> As a bunch of commits hit networking I CC DaveM and
> here so the can nod/object to these, I think
> the want a bit of control over what goes into networking
> stable.
> 
> I avoided two patch sets dealing with IPv6 tunneling
> and netfilter that seem to still be fixed and I feel generally
> incompetent about.
> 
> For the remaining patches I cherry-picked the upstream
> commits except for (8/10)
> "netfilter: nf_tables: fix mismatch in big-endian system"
> where I used OpenWrt's backport.
> 
> The list of upstream commits in patch order:
> 6db6f0eae6052b70885562e1733896647ec1d807
> "bridge: multicast to unicast"
> e9156cd26a495a18706e796f02a81fee41ec14f4
> "smsc95xx: Use skb_cow_head to deal with cloned skbs"
> 6bc6895bdd6744e0136eaa4a11fbdb20a7db4e40
> "ch9200: use skb_cow_head() to deal with cloned skbs"
> 39fba7835aacda65284a86e611774cbba71dac20
> "kaweth: use skb_cow_head() to deal with cloned skbs"
> 854826c9d526fd81077742c3b000e3f7fcaef3ce
> "ubifs: Drop softlimit and delta fields from struct ubifs_wbuf"
> 1b7fc2c0069f3864a3dda15430b7aded31c0bfcc
> "ubifs: Use dirty_writeback_interval value for wbuf timer"
> cd4b1e34655d46950c065d9284b596cd8d7b28cd
> "usb: dwc2: Remove unnecessary kfree"
> 10596608c4d62cb8c1c2b806debcbd32fe657e7
> "netfilter: nf_tables: fix mismatch in big-endian system"
> 65cab850f0eeaa9180bd2e10a231964f33743edf
> "net: Allow class-e address assignment via ifconfig ioctl"
> 6926e041a8920c8ec27e4e155efa760aa01551fd
> "uapi/if_ether.h: prevent redefinition of struct ethhdr"

Ick that's hard to read.  Going with a bit longer line is better:

6db6f0eae6052b70885562e1733896647ec1d807 "bridge: multicast to unicast"
e9156cd26a495a18706e796f02a81fee41ec14f4 "smsc95xx: Use skb_cow_head to deal with cloned skbs"
6bc6895bdd6744e0136eaa4a11fbdb20a7db4e40 "ch9200: use skb_cow_head() to deal with cloned skbs"
39fba7835aacda65284a86e611774cbba71dac20 "kaweth: use skb_cow_head() to deal with cloned skbs"
854826c9d526fd81077742c3b000e3f7fcaef3ce "ubifs: Drop softlimit and delta fields from struct ubifs_wbuf"
1b7fc2c0069f3864a3dda15430b7aded31c0bfcc "ubifs: Use dirty_writeback_interval value for wbuf timer"
cd4b1e34655d46950c065d9284b596cd8d7b28cd "usb: dwc2: Remove unnecessary kfree"
10596608c4d62cb8c1c2b806debcbd32fe657e7 "netfilter: nf_tables: fix mismatch in big-endian system"
65cab850f0eeaa9180bd2e10a231964f33743edf "net: Allow class-e address assignment via ifconfig ioctl"
6926e041a8920c8ec27e4e155efa760aa01551fd "uapi/if_ether.h: prevent redefinition of struct ethhdr"

Or better yet, use the "standard" way we reference ids in the kernel:
6db6f0eae605 ("bridge: multicast to unicast")
e9156cd26a49 ("smsc95xx: Use skb_cow_head to deal with cloned skbs")
...

Anyway, I need those ids in the patches themselves, as we do for all
stable patches (look at how they look in the stable trees for examples).

Also, some of these are in kernels newer than 4.14, so if I were to
apply them to 4.9 only, someone moving to a newer kernel would have a
regression, which isn't ok.

65cab850f0ee ("net: Allow class-e address assignment via ifconfig
ioctl") is one such example of that type of patch.

So I can't take these as-is, sorry.

greg k-h

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list