[OpenWrt-Devel] [PATCH v4 3/5] ath79: add support for Netgear WNR2000 v3

Adrian Schmutzler mail at adrianschmutzler.de
Tue Aug 13 07:03:55 EDT 2019

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org] On Behalf Of Michal Cieslakiewicz
> Sent: Dienstag, 13. August 2019 10:52
> To: openwrt-devel at lists.openwrt.org
> Cc: Adrian Schmutzler <mail at adrianschmutzler.de>
> Subject: [OpenWrt-Devel] [PATCH v4 3/5] ath79: add support for Netgear WNR2000 v3
> This patch adds ath79 support for Netgear WNR2000v3.
> Router was previously supported by ar71xx target only.
> Note: this is a 4_32 device with limited upgrade capabilities.

Sorry, found two things again.

> +	ucidef_set_led_default "wan-green" "WAN (green)" "netgear:green:wan" "0"

Can this be done with default-state = off in DTS?

> +&gpio {
> +	status = "okay";
> +};

I think this is not required as gpio is not disabled. But please test.

As those changes are minor, maybe wait with a v5 until you receive feedback from someone else, then ...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190813/93593652/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list