[OpenWrt-Devel] [PATCH 2/2 netifd] proto-shell: return error in case setup fails

Hans Dedecker dedeckeh at gmail.com
Mon Apr 1 04:34:27 EDT 2019


In case PROTO_CMD_SETUP cannot be handled due to an invalid state; return
-1 so the calling functions are aware the PROTO_CMD_SETUP has failed.

Signed-off-by: Hans Dedecker <dedeckeh at gmail.com>
---
 proto-shell.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/proto-shell.c b/proto-shell.c
index 9653f4c..fd9cad4 100644
--- a/proto-shell.c
+++ b/proto-shell.c
@@ -184,8 +184,6 @@ proto_shell_handler(struct interface_proto_state *proto,
 		case S_SETUP_ABORT:
 		case S_TEARDOWN:
 		case S_SETUP:
-			return 0;
-
 		default:
 			return -1;
 		}
-- 
2.19.2


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list