[OpenWrt-Devel] [RFC PATCH] build: re-enable parallelism for mksquashfs

[Daniel Santos]

This was disabled by commit dcd0e4a6727611f03eb3d3a75f073235f5f1229c due
to a threading bug back in 2009.  The specifics of the bug are not given
in the commit message and squashfs-tools has had several updates to it's
parallelism since this time.  There are currently no open issues related
to parallelism in their issue tracker:
https://github.com/plougher/squashfs-tools/issues

It now "works for me" with 16 threads, and while this is a terrible test
for a race condition I still propose we remove this work-around
unless and until we have specific knowledge of a current bug.

Signed-off-by: Daniel Santos <daniel.santos at pobox.com>
---
 include/image.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/image.mk b/include/image.mk
index f2a85f6feb..dcf1e3572a 100644
--- a/include/image.mk
+++ b/include/image.mk
@@ -203,7 +203,6 @@ define Image/mkfs/squashfs
 	$(STAGING_DIR_HOST)/bin/mksquashfs4 $(call mkfs_target_dir,$(1)) $@ \
 		-nopad -noappend -root-owned \
 		-comp $(SQUASHFSCOMP) $(SQUASHFSOPT) \
-		-processors 1 \
 		$(if $(SOURCE_DATE_EPOCH),-fixed-time $(SOURCE_DATE_EPOCH))
 endef
 
-- 
2.16.4


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel