[OpenWrt-Devel] Broken GPIO on MT7620 after commit 34ca34b32b02

Rosen Penev rosenp at gmail.com
Tue May 22 12:03:38 EDT 2018


On Tue, May 22, 2018 at 7:33 AM, John Crispin <john at phrozen.org> wrote:
>
>
> On 22/05/18 16:18, Kristian Evensen wrote:
>>
>> On Sun, May 20, 2018 at 10:26 PM, Rosen Penev <rosenp at gmail.com> wrote:
>>>>
>>>> Bisecting further is hard, since the
>>>> commit is a combination of (a lot of) clean-up and some functional
>>>> changes.
>>>
>>> Changes can be viewed on the linux-next tree. It should be as simple
>>> as dropping in the relevant files to the files-4.14 directory.
>>>
>>>> Would it be possible to revert the commit and split it in two
>>>> parts (clean-up + functional)? Then it should be easier to figure out
>>>> what is wrong.
>>>
>>> I'm torn on this. The long term solution is to migrate to the mainline
>>> mtk-sd driver (which is just a newer version of this one). The new
>>> 18.06 release does not contain this patch.
>>
>> I agree that using the mainline driver is ideal. This email was meant
>> more as a notification that the commit creates issues for some
>> devices. I didnt test, but I guess that my LEDs are also broken, since
>> some are also controlled using GPIO. For me, reverting the commit
>> locally works fine and I can carry that locally.
>>
>> BR,
>> Kristian
>
>
> what exactly is the issue ? breaking compat means that rosen either needs to
> fix the regression or we need to revert the patch.
I will look into this later today. I'm simultaneously working on
getting the mainline driver up and running on mt7621. Will submit an
RFC for that soon.
>
>     John

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
http://lists.infradead.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list