[OpenWrt-Devel] [PATCH v2] build: download code from github using archive API

Jo-Philipp Wich jo at mein.io
Fri Jun 29 01:15:37 EDT 2018


Hi Yousong,

this change seems to introduce serious runtime regressions, see
https://bugs.openwrt.org/index.php?do=details&task_id=1621

It seems to be like that script does things even if the tarballs are
already existing locally.

On a slightly related note, I find the name to be too generic. It
implies that it handles all kinds of download tasks but in the end it is
only a Github archive wrapper. Maybe you should rename it to github.py
or similar.

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20180629/2f2c87e5/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list