[OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

Kevin Darbyshire-Bryant kevin at darbyshire-bryant.me.uk
Wed Jul 11 06:38:39 EDT 2018

> On 11 Jul 2018, at 10:44, Hannu Nyman <hannu.nyman at iki.fi> wrote:
> Kevin Darbyshire-Bryant wrote:
>> Really not convinced I agree with the "patch 335 removes the whole code block where that one line changed in upstream”.
> You are right.
> The corresponding addition needs to be done for the lines replacing the removed lines:
> 932 + if (filter && filter->table[0] &&
> should likely be
> 932 + if (filter && filter->table &&
> matching the change done upstream.
> In my comment I overlooked the part where we add back similar lines :-(

lol - I’m really happy….it turns out I’m not *completely* stupid :-)

> (the refresh patch only notices the need to refresh the upstream lines, but does not know about out own additions.)

Reading patches to patches is….challenging.   I wonder if there’s a tool that would make it easier?



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20180711/b8040abd/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list