[OpenWrt-Devel] [PATCH] treewide: dts: Unify naming of gpio-keys nodes

Christian Lamparter chunkeey at gmail.com
Mon Dec 31 11:41:34 EST 2018

On Sunday, December 30, 2018 12:17:25 PM CET Petr Štetiar wrote:
> In DTS Checklist[1] we're now demanding proper generic node names, as
> the name of a node should reflect the function of the device and use
> generic name for that[2]. Everybody seems to be copy&pasting from DTS
> files available in the repository today, so let's unify that naming
> there as well and provide proper examples.
> 1. https://openwrt.org/submitting-patches#dts_checklist
> 2. https://github.com/devicetree-org/devicetree-specification/blob/master/source/devicetree-basics.rst#generic-names-recommendation
> Signed-off-by: Petr Štetiar <ynezz at true.cz>
> ---

Another source of the "gpio-keys" and the "gpio_keys_polled" 
node names are the binding examples in


As a result, these node-names are really common in a lot of upstream bindings
(I grepped around 350 gpio(_|-)keys* nodes located in various .dts and .dtsi
files under linux-kernel/arch/... ).

I hope you know what you are up against because unless you also do the changes
upstream this will happen again and again. :\ / :)


openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list