[OpenWrt-Devel] [PATCH]:for demand option in l2tp.sh file of xl2tpd package.

Yousong Zhou yszhou4tech at gmail.com
Thu May 19 07:25:57 EDT 2016


On 19 May 2016 at 19:17, Yousong Zhou <yszhou4tech at gmail.com> wrote:
> On 19 May 2016 at 18:50, Pranay Goud <mogulapranay57 at gmail.com> wrote:
>> Hi Developers,
>>
>>
>>
>> Below patch is for considering demand option in l2tp.sh, demand option is
>> not getting initialized
>>
>>
>>
>> json_get_vars ipv6 demand keepalive username password pppd_options
>>
>>
>>
>> the above line in l2tp.sh fails to read demand option and whenever user
>> changes only demand option (idle time value) xl2tp dameon is not notified.
>>
>
> Hi Pranay, please try patch at [1] and see if it can fix the issue for you.
>
> Thanks for reporting this.  Xl2tpd for OpenWrt is hosted in the
> packages feed [2].  Opening issues/pull requests there should be the
> way to go.
>
> [1] xl2tpd: add missing "demand" option,
> https://github.com/yousong/packages/commit/e6d4e73420b21f033fb77cf0c2adb0f3b957dcc8
> [2] https://github.com/openwrt/packages
>

Ooh, sorry... just noticed that the change was the same...

To let the change get merged, the commit will need to be signed-off-by
you.  Please consider opening a pr at the github page

>                 yousong
>
>>
>>
>> --- a/package/openwrt/net/xl2tpd/files/l2tp.sh
>>
>> +++ b/package/openwrt/net/xl2tpd/files/l2tp.sh
>>
>> @@ -14,6 +14,7 @@ proto_l2tp_init_config() {
>>
>>         proto_config_add_string "keepalive"
>>
>>         proto_config_add_string "pppd_options"
>>
>>         proto_config_add_boolean "ipv6"
>>
>> +      proto_config_add_int "demand"
>>
>>         proto_config_add_int "mtu"
>>
>>         proto_config_add_string "server"
>>
>>         available=1
>>
>>
>>
>>
>>
>>
>>
>> Thanks,
>>
>> Pranay.
>>
>>
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel at lists.openwrt.org
>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>>
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list